Skip to content

Descriptor leak at iam-import #5128

@wooffie

Description

@wooffie

What I see:

We open new file descriptor here:

f, e := os.Open(args.Get(1))

It will be closed by defer:

defer f.Close()

After we open one more descriptor:

f, e = os.Open(args.Get(1))

We put him in functions ImportIAMV2(ctx context.Context, contentReader io.ReadCloser) or ImportIAM(ctx context.Context, contentReader io.ReadCloser)

Its takes ReadCloser, but not use Close().

In result second file descriptor is not closed. We can add one more defer f.Close() to handle this case

P.S. or it is closed by another code and I didn't found this =0

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions