fix: previous server always nil #540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbraemer
added a commit
that referenced
this pull request
Jun 12, 2025
fixes #539 closes #540 - Added a `previousServer` field to `ServerPreConnectEvent` and `serverConnection` to track the server a player was previously connected to. - Updated constructors and methods to accommodate the new `previousServer` parameter, improving connection request handling and event firing. - Enhanced `createConnectionRequest` to include the previous connection for better context during server transitions.
robinbraemer
added a commit
that referenced
this pull request
Jun 13, 2025
* fix: PreviousServer is always nil fixes #539 closes #540 - Added a `previousServer` field to `ServerPreConnectEvent` and `serverConnection` to track the server a player was previously connected to. - Updated constructors and methods to accommodate the new `previousServer` parameter, improving connection request handling and event firing. - Enhanced `createConnectionRequest` to include the previous connection for better context during server transitions. * fix: Prevent storing typed nil pointers for previousServer - Updated the handling of the previousServer field in ServerConnectedEvent and ServerPostConnectEvent to ensure it is only assigned when non-nil, preventing incorrect nil pointer storage. - This change enhances the integrity of event data during server transitions, ensuring accurate tracking of previous connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #539
Also fixes the logs in the console about on which server the player is (currently always says that a player joined the initial server).