T 1404619: Update new network error condition in OAuth2Error #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
Handle network failures by adding a new error case for network failures and updating the error handling logic for
refresh token API
for this new case.Implementation
networkFailure
to theOAuth2Error
enum to represent network failures.errorFrom
method to accept an additionalerror
parameter and returnOAuth2Error.networkFailure
for network-related errors.errorFrom
to pass the newerror
parameter.Test Plan
Refresh Token
API and verify if the error returningOAuth2Error.networkFailure
when received network error (NSURLDomainErrorCode is < 0).