Aggsig signature subtraction function, rust side #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tromp
reviewed
May 15, 2023
tromp
reviewed
May 15, 2023
tromp
approved these changes
May 15, 2023
vekamo
added a commit
to mwcproject/rust-secp256k1-zkp
that referenced
this pull request
Sep 9, 2023
* Update CI (mimblewimble#65) * attempt to fix windows build * remove all explicit rust installation steps * update mac os image * Implement PartialOrd and Ord (mimblewimble#62) * Implement PartialOrd and Ord * Fix spaces * Add create commit from pubkey function (mimblewimble#64) * Update azure to use latest, fix warnings (mimblewimble#66) * update azure to use latest, fix warnings * add toolchain commands * Fix Win CI * Go back to previous command * The Fix Co-authored-by: Quentin Le Sceller <q.lesceller@gmail.com> * version bump for release (mimblewimble#67) * fix from_pubkey function * Revert "fix from_pubkey function" This reverts commit a5f08e3. * Update Grin Website * Commit to pubkey fix (mimblewimble#68) * commit_to_pubkey fix * version bump for next release * retrigger build * Fix compiler warning (mimblewimble#70) * Fuzz tests for various components * Fix error formatting (mimblewimble#75) * Update version to v0.7.10 * Update zeroize dependency (mimblewimble#78) * Bump version to v0.7.11 (mimblewimble#79) * update dependency seck256k1 branch to latest master with aggsig subtraction function * Aggsig signature subtraction function, rust side (mimblewimble#81) * addition of ffi+api functions for aggsig partial sig subtract * updated aggsig lib function to return more results based on underlying function * update submodule to latest master * clean up test result check * bump version number * update depend/secp256k1-zkp * update version --------- Co-authored-by: Yeastplume <yeastplume@protonmail.com> Co-authored-by: jaspervdm <j@sper.dev> Co-authored-by: Quentin Le Sceller <q.lesceller@gmail.com> Co-authored-by: Nym Seddon <unseddd@shh.xyz> Co-authored-by: GeneFerneau <80422284+GeneFerneau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this depends on: mimblewimble/secp256k1-zkp#67, that will need to be merged and the submodule updated before this change can be commit.
The rust FFI interface + api implementation of
subtract_partial_signature, along with some test additions to exercise and verify it. Will only be used in the experimental contracts wallet branch for early payment proof verification.