Skip to content

Fix Windows CI cargo test silently passing #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fix Windows CI cargo test silently passing #603

merged 2 commits into from
Apr 7, 2021

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Apr 5, 2021

Counterpart to mimblewimble/grin#3632, fixes Windows cargo test to actually test instead of silently passing.

quentinlesceller
quentinlesceller reviewed Apr 7, 2021
View reviewed changes
quentinlesceller
quentinlesceller approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI pass.

@quentinlesceller quentinlesceller merged commit 5ccca2d into mimblewimble:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevyn @quentinlesceller