[DNM] [5.0.x] Replace custom hyper client with reqwest #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a great improvement 👍 .
Sure ping me anytime! |
|
For some reason the tests are failing on Windows, I will try to debug it on my machine after the weekend as I don't have access to it before then. |
|
Looks like a random error. I triggered another run. |
|
This seems good, any other issues with this PR? Can we merge it now? |
|
@quentinlesceller can we close this one? |
|
Yes indeed we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our HTTP client that interfaces with the node and other wallets is using some pretty low level hyper code. It uses separate dependencies for tls and timeouts. On top of that, it uses a Tokio runtime that is spun up for every request separately, which is inefficient and tends to fail at some point (see #509).
This PR replaces the hyper code by the reqwest library, which is well reviewed and maintained and using it simplifies our code.
Instead of creating a tokio runtime for each request, use a global runtime. Unfortunately, until reqwest updates to tokio 0.3, the runtime will have to be behind a
Mutex.