Skip to content

add "compat" output features #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add "compat" output features #503

wants to merge 1 commit into from

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Aug 7, 2020 •
edited
Loading

Related - #499.
Related - mimblewimble/grin#3416.

V4 cleanup introduced a breaking change to the CbData response.

Old -

"output": {
    "commit": "08fe198e525a5937d0c5d01fa354394d2679be6df5d42064a0f7550c332fce3d9d",
    "features": "Coinbase",
    "proof": "9d8488fc..."
}

New -

"output": {
    "com": "08fe198e525a5937d0c5d01fa354394d2679be6df5d42064a0f7550c332fce3d9d",
    "features": 1,
    "prf": "9d8488fc..."
}

This PR ensures we now produce the expected json when node requests CbData via build_coinbase.

We actually no longer need TransactionV4 and the various related data structures.
This PR cleans this up, allowing the use of a simplified CoinbaseV4 with nested CbOutputV4 and CbKernelV4.

@antiochp
Copy link
Member Author

antiochp commented Aug 7, 2020

I think we can actually clean a lot of this code up.
99% cure we no longer use TransactionV4 at all and the only place we need "compat" features is in the build_coinbase api call from node.

I'll see if I can get something working and put a PR up.

@antiochp antiochp mentioned this pull request Aug 7, 2020
Closed
@antiochp antiochp force-pushed the compat_output_features branch from 9d9ad4a to 2d91528 Compare August 7, 2020 16:40
@antiochp antiochp closed this Aug 7, 2020
@antiochp antiochp reopened this Aug 7, 2020
@antiochp antiochp force-pushed the compat_output_features branch from 2d91528 to 0f5ea0c Compare August 7, 2020 17:24
@antiochp antiochp closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antiochp