Skip to content

Fix Windows CI cargo test silently passing #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 7, 2021
Merged

Fix Windows CI cargo test silently passing #3632

merged 5 commits into from
Apr 7, 2021

Conversation

trevyn
Copy link
Contributor

@trevyn trevyn commented Apr 5, 2021 •
edited
Loading

I don't really know why, but the changes I made in the CI scripts for #3596 were causing the Windows CI tests to silently pass without doing anything. Changing the way the env variables are set seems to fix this, the full tests now run. grin-wallet counterpart in a moment.

Starting: Windows Cargo Test
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\a4073cdf-5e02-40b8-8632-2b6fd7d6a3c8.cmd""
Refreshing environment variables from registry for cmd.exe. Please wait...Finished..
Finishing: Windows Cargo Test

@trevyn trevyn mentioned this pull request Apr 5, 2021
Merged
@trevyn trevyn changed the title [WIP] Fix Windows CI cargo test Fix Windows CI cargo test silently passing Apr 5, 2021
@trevyn trevyn marked this pull request as ready for review April 5, 2021 17:35
@antiochp
Copy link
Member

antiochp commented Apr 5, 2021

Good catch.
I think something similar has actually bitten us in the past. I think it involves the first command returning 0 and treated as success or something similar.

antiochp
antiochp reviewed Apr 5, 2021
View reviewed changes
@trevyn trevyn requested a review from antiochp April 7, 2021 08:38
quentinlesceller
quentinlesceller approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good LGTM.

@quentinlesceller quentinlesceller merged commit f8afdb5 into mimblewimble:master Apr 7, 2021
@antiochp antiochp mentioned this pull request May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

@antiochp antiochp Awaiting requested review from antiochp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trevyn @antiochp @quentinlesceller