implement fix past fees RFC with fee shift since genesis #3629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBurkett
reviewed
Apr 4, 2021
| let height = 42; // arbitrary | ||
| assert!(tx1.validate(Weighting::AsTransaction, height).is_ok()); | ||
| assert!(tx2.validate(Weighting::AsTransaction, height).is_ok()); | ||
|
|
There was a problem hiding this comment.
nit: remove superfluous blank line
DavidBurkett
approved these changes
Apr 4, 2021
|
We should block the merge of this one until mimblewimble/grin-rfcs#77 is accepted |
|
Yes, that's what it says in top description:-) |
|
Woops, missed it. But I did mean a literal merge block by making the PR draft (WIP, DNM or similar) |
antiochp
reviewed
Apr 6, 2021
|
#3634 updates the config file -
as part of updating the config file to "version 2". So we should be safe to include cleanup around the "rewriting" of this config item at startup in this PR. |
|
@tromp what's the state of this one? |
|
Ready to be merged upon approval. |
GeneFerneau
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: fixpastfees
about: remove dependence of fee() and fee_shift() functions on height
title: 'fix past fees'
labels: ''
assignees: ''
This PR implements the "fix past fees" RFC at https://github.com/mimblewimble/grin-rfcs/blob/master/text/0021-fix-prior-fees.md
It is consensus breaking in the weakest possible sense, in that older clients can disagree only if a many months deep reorg occurs that includes a > 40 bit fee (roughly 1100 Grin) prior to HF4.
This code has been tested on a sync-from-scratch.
No new tests are added, and only a few were removed that used to test that> 40 bit fees were allowed prior to HF4.