Skip to content

fix: register missing investors module #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2025
Merged

fix: register missing investors module #283

merged 3 commits into from
Apr 26, 2025

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Apr 26, 2025 •
edited by coderabbitai bot
Loading

Description

This PR adds the missing investors module registration. Also, since the investors module doesn't use the module account the PR removes it from moduleAccPerms.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features

    • Integrated the investors module into the application, enabling its participation during app initialization and block processing.

  • Chores

    • Removed an unused constant related to foundation address.
    • Cleaned up module account handling in the investors module initialization.

@hallazzang hallazzang self-assigned this Apr 26, 2025
@hallazzang hallazzang requested review from RiccardoM and manu0466 and removed request for RiccardoM April 26, 2025 12:31
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 26, 2025 •
edited
Loading

Walkthrough

The changes integrate the investors module into the application's lifecycle by importing and registering it in the main app modules and including it in the begin block execution order. The module account permissions map remains unchanged. Additionally, a constant foundationAddress was removed from the upgrade handler in v11-warp-fix. In the investors module genesis initialization, a redundant call to create the module account was removed. No exported or public interfaces were altered; all modifications are internal to module registration, initialization, and upgrade logic.

Changes

File(s) Change Summary
app/modules.go Imported and registered the investors module; added it to begin blockers order; no changes to permissions map.
app/upgrades/v11-warp-fix/upgrades.go Removed the foundationAddress constant; no other changes.
x/investors/keeper/genesis.go Removed redundant call to create module account in InitGenesis.

Suggested reviewers

  • manu0466

Poem

In the garden of code where new modules grow,
The investors now join, in the app’s steady flow.
Old addresses pruned, permissions made neat,
Genesis refreshed, with logic complete.
With every new block, the system will sing—
Hooray for the changes that spring with the spring!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5f81b9 and 8b42506.

📒 Files selected for processing (1)
  • app/modules.go (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/modules.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test-sim-import-export
  • GitHub Check: test-sim-multi-seed-short
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hallazzang hallazzang requested a review from RiccardoM April 26, 2025 12:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 26, 2025, 2:46 PM

@hallazzang hallazzang force-pushed the hallazzang/register-missing-investors-module branch from 7a7582b to b5f81b9 Compare April 26, 2025 12:33
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@hallazzang hallazzang marked this pull request as ready for review April 26, 2025 12:58
manu0466
manu0466 reviewed Apr 26, 2025
View reviewed changes
@hallazzang hallazzang requested a review from manu0466 April 26, 2025 14:34
@hallazzang hallazzang merged commit e8567a5 into main Apr 26, 2025
22 checks passed
@hallazzang hallazzang deleted the hallazzang/register-missing-investors-module branch April 26, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manu0466 manu0466 manu0466 approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@RiccardoM RiccardoM Awaiting requested review from RiccardoM

Assignees

@hallazzang hallazzang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallazzang @manu0466