-
Notifications
You must be signed in to change notification settings - Fork 4
refactor!: remove x/feemarket module #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis set of changes removes all code related to the FeeMarket module from the application. All references, imports, keepers, decorators, handlers, and logic associated with FeeMarket are deleted from the ante handler, application initialization, keepers, modules, and post-handler setup. The FeeMarket’s store key is now marked for deletion in the v11 upgrade constants. The codebase is refactored to rely solely on standard Cosmos SDK fee handling mechanisms, eliminating FeeMarket-specific fee checking, deduction, and post-processing logic. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CosmosSDK
participant App
User->>App: Submit Transaction
App->>CosmosSDK: AnteHandler (no FeeMarket logic)
CosmosSDK->>App: Standard Fee Checking & Deduction
App->>User: Transaction Result
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (9)
💤 Files with no reviewable changes (6)
🔇 Additional comments (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Description
This PR removes x/feemarket module.
Closes: MILK-259
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
Refactor
Chores