Add with_starting_date function for DateSelect #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great point. When I saw your PR I was surprised to see I hadn't written this function too. Turns out that I did, but it is called I'll merge your PR as-is and do some small changes after that, it will be in the next release! |
mikaelmello
approved these changes
Jan 9, 2023
|
0.5.3 has your feature :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this function myself, and apparently it doesn't currently exist.
I don't see why you wouldn't want this function, but if there's some reason for it, feel free to close the PR.
Even though the change is trivial, I added an example to sanity check that everything was still working, if you don't want the extra example, let me know and I'll update the PR.