Skip to content

edns: add missing dig options #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

edns: add missing dig options #1389

merged 2 commits into from
Jan 5, 2023

Conversation

SamTherapy
Copy link
Contributor

Adds to opt.String() making the opt printing more like dig.

The &0x7FFF is like dig, which doesn't display the DO flag even when set (see below)

❯ dig +ednsflags=12 +expire github.com +qr +dnssec

; <<>> DiG 9.18.4-2-Debian <<>> +ednsflags +expire github.com +qr +dnssec
;; global options: +cmd
;; Sending:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 56825
;; flags: rd ad; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags: do; MBZ: 0x000c, udp: 1232
; COOKIE: 
; EXPIRE:
;; QUESTION SECTION:
;github.com.                    IN      A

;; QUERY SIZE: 55

@SamTherapy
edns: add missing dig options
240a2ed 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
@SamTherapy SamTherapy requested review from miekg and tmthrgd as code owners July 30, 2022 13:48
tmthrgd
tmthrgd requested changes Aug 1, 2022
View reviewed changes
@SamTherapy
Apply suggested change
7b732ec 
Signed-off-by: Sam Therapy <sam@samtherapy.net>
@SamTherapy SamTherapy requested review from tmthrgd and removed request for miekg September 3, 2022 13:01
@miekg miekg merged commit caa3fe0 into miekg:master Jan 5, 2023
@SamTherapy SamTherapy deleted the dig-edns-printing branch January 5, 2023 14:47
monoidic added a commit to monoidic/dns that referenced this pull request Feb 18, 2023
@monoidic
upstream PR miekg#1389 by SamTherapy
5d7d6e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmthrgd tmthrgd Awaiting requested review from tmthrgd tmthrgd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamTherapy @tmthrgd @miekg