Add notes about SVCB draft changes to SVCB-related API #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've decided to only add those notes to types and constants for now. This, as well as the precise wording of the warning, are up to discussion. |
|
[ Quoting ***@***.***> in "[miekg/dns] Add notes about SVCB dr..." ]
See discussion in #1359.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You can view, comment on, or merge this pull request online at:
#1364
Commit Summary
• 21ec7fc Add notes about SVCB draft changes to SVCB-related API
File Changes
(1 file)
• M svcb.go (39)
Patch Links:
• https://github.com/miekg/dns/pull/1364.patch
• https://github.com/miekg/dns/pull/1364.diff
I think this is too excessive. What would be a good spot to put this note is
on the `type SVCB struct` definition. And the HTTPS one.
Probably also note that this mostly applies to the SVCBKeyValue handling?
|
|
@miekg, done. |
miekg
approved these changes
Apr 14, 2022
|
https://datatracker.ietf.org/doc/draft-ietf-dnsop-svcb-https/ is heading for RFC - so the changes going forward will be minimal, would be good to see what needs to be changed and remove the warnings |
|
@miekg, I'll try to keep up with the drafting process and send a PR when the RFC is out. |
aanm
pushed a commit
to cilium/dns
that referenced
this pull request
Jul 29, 2022
* Add notes about SVCB draft changes to SVCB-related API * Decrease number of warnings, rephrase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1359.