Skip to content

Fix dig-like output #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 24, 2021
Merged

Fix dig-like output #1320

merged 1 commit into from Dec 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2021

Fix location of opt pseudosection and prevent empty additional section in dig-like output

Before:

;; opcode: QUERY, status: NOERROR, id: 1234
;; flags: cd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; QUESTION SECTION:
;example.com. IN A

;; ADDITIONAL SECTION:

;; OPT PSEUDOSECTION:
; EDNS: version 0; flags: do; udp: 512

After:

;; opcode: QUERY, status: NOERROR, id: 1234
;; flags: cd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version 0; flags: do; udp: 512

;; QUESTION SECTION:
;example.com. IN A

@ghost ghost requested review from miekg and tmthrgd as code owners December 24, 2021 16:42
@miekg
Copy link
Owner

miekg commented Dec 24, 2021 via email

cbot[bot]
cbot bot approved these changes Dec 24, 2021
View reviewed changes
Copy link

@cbot cbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by miekg

@miekg
Copy link
Owner

miekg commented Dec 24, 2021 via email

@cbot cbot bot merged commit af5144a into miekg:master Dec 24, 2021
aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
@aanm
Fix location of opt pseudosection and prevent empty additional sectio…
1a1a564 
…n in dig-like output (miekg#1320)

Automatically submitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg Awaiting requested review from miekg miekg is a code owner

@tmthrgd tmthrgd Awaiting requested review from tmthrgd tmthrgd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miekg