Add ResponseWriter.Net function #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miekg
reviewed
May 30, 2025
|
reverting because not backwards compatible (although that creates another bump for users that did uprade) |
miekg
added a commit
that referenced
this pull request
Aug 3, 2025
This reverts commit 96a6b9c. (not backwards compatible)
miekg
added a commit
that referenced
this pull request
Aug 3, 2025
|
curious how is it not bw compatible to add a method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Net() stringtoResponseWriterwhich returns the correspondingServer'sNetvalue (e.g., "tcp", "tcp-tls").This makes it easy, for example, to gate logic in a
Handlerbased on the transport protocol, such as adding EDNS0 Padding to responses when using TLS.Cheers!