Avoid sendmsg control messages on darwin #1643
Conversation
sendmsg with PKTINFO is broken on darwin, so don't use it udp_windows is renamed to udp_no_control since it's no longer exlusive to windows, and is used on darwin too
|
this is an issue with XNU itself and not with this library or with Go, so it's a workaround to avoid using broken OS APIs sidenote: does using sendmsg make any sense if the socket is already bound to a non- 0.0.0.0 address? maybe it's better to avoid sendmsg completely if socket is bound to an IP? |
|
@miekg @tmthrgd PTAL: I've been successfully running coredns with this patch on macOS for some time with no issues I highly doubt that macOS go servers are used with non-trivial routing setups where PKTINFO is necessary, but I'm willing to implement an adaptive approach where PKTINFO is unused only if there's a non-ANY binding on the socket if necessary |
|
thanks for this, I have no way of knowing if this is the correct approach, but happy to try it. We have some old bugs of weird things on macos that noone understood/understands |
|
@miekg could you please make a new release with this fix, so the fix gets into coredns? |
fixed by updating to miekg/dns@v1.1.65 in coredns#7240 upstream bug was fixed by miekg/dns#1643 Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
fixed by updating to miekg/dns@v1.1.65 in #7240 upstream bug was fixed by miekg/dns#1643 Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
sendmsg with PKTINFO is broken on darwin, so don't use it
udp_windows is renamed to udp_no_control since it's no longer exlusive to windows, and is used on darwin too
fixes #724 and #941