Annotate unpack* function errors with where the error happened. #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good, however a whole bunch of is popping up in the tests.... |
da17676 to
8ba105b
Compare
Oops sorry forgot to add my latest changes... |
This commit adds annotations to the error message when an error occurs during unpacking of a DNS message, the annotation will give detiail on where in the DNS message the unpacking error occured at. This helps to improve the debugability of such errors.
|
@miekg Does it look better now on your end as well? |
|
@miekg Small bump for this MR. |
|
@miekg Hey do you think there is a possibility to merge this MR? |
|
I did not get the idea this was fully fleshed out |
|
It should be complete for the unpack functions, perhaps the question is if there are more things were this could also be useful. But for our own use case this should do the job. |
|
ok, I'll likely fiddle with the exact wording for the errors, but merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first stab at the code for #1576
This commit adds annotations to the error message when an error occurs during unpacking of a DNS message, the annotation will give detiail on where in the DNS message the unpacking error occured at. This helps to improve the debugability of such errors.