Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.11.0
Choose a base ref
...
head repository: microsoft/hcsshim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.11.1
Choose a head ref
  • 9 commits
  • 64 files changed
  • 6 contributors

Commits on Sep 20, 2023

  1. [release/0.11] Cherry-pick testing fixes from v0.10.0-rc.9 and update… 

    … containerd version used (#1881)

* update to latest containerd/1.6 tag v1.6.23

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

* fix integration test failure (#1799)

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit f5c5797)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

* Checkout appropriate containerd ref

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

* skip failing test, use gotestsum (#1820)

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit 4ede1fd)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

* Cleanup tests that are skipped in CI:
Removes TestConvert() from being skipped as corresponding fix made to v1.6.22
Skip TestContainerSymlinkVolumes() tests as it seems to pass only with containerd/1.7

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

---------

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Co-authored-by: Hamza El-Saawy <84944216+helsaawy@users.noreply.github.com>
    @kiashok @helsaawy
    kiashok and helsaawy authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9c3272e View commit details
    Browse the repository at this point in the history

  2. Revert "[release/0.11] Cherry-pick testing fixes from v0.10.0-rc.9 an… 

    …d update containerd version used (#1881)" (#1911)

This reverts commit 9c3272e.
    @kiashok
    kiashok authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    cba2f73 View commit details
    Browse the repository at this point in the history

  3. update to latest containerd/1.6 tag v1.6.23 

    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    @kiashok
    kiashok committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7e652d5 View commit details
    Browse the repository at this point in the history

  4. fix integration test failure (#1799) 

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit f5c5797)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    @helsaawy @kiashok
    helsaawy authored and kiashok committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    623db83 View commit details
    Browse the repository at this point in the history

  5. Checkout appropriate containerd ref 

    Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    @kiashok
    kiashok committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d10bd0b View commit details
    Browse the repository at this point in the history

  6. skip failing test, use gotestsum (#1820) 

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit 4ede1fd)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    @helsaawy @kiashok
    helsaawy authored and kiashok committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    eb50291 View commit details
    Browse the repository at this point in the history

  7. Cleanup tests that are skipped in CI: 

    Removes TestConvert() from being skipped as corresponding fix made to v1.6.22
Skip TestContainerSymlinkVolumes() tests as it seems to pass only with containerd/1.7

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
    @kiashok
    kiashok committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    134c4a2 View commit details
    Browse the repository at this point in the history

  8. defaulting to unbuffered reader for dmverity hashing (#1887) 

    Signed-off-by: Seth Hollandsworth <sethho@microsoft.com>
Co-authored-by: ksayid <khalilsayid@microsoft.com>
(cherry picked from commit e7509cc)
Signed-off-by: Maksim An <maksiman@microsoft.com>
    @SethHollandsworth @ksayid @anmaxvl
    2 people authored and anmaxvl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b497608 View commit details
    Browse the repository at this point in the history

  9. Fix closing stdin (#1899) 

    Send the modify request even if stdin is nil, let the process handle it

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
(cherry picked from commit 27df1b9)
Signed-off-by: Maksim An <maksiman@microsoft.com>
    @rumpl @anmaxvl
    rumpl authored and anmaxvl committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    641f8b8 View commit details
    Browse the repository at this point in the history
Loading