Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/TypeScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.2
Choose a base ref
...
head repository: microsoft/TypeScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.7.3
Choose a head ref
  • 20 commits
  • 82 files changed
  • 5 contributors

Commits on Nov 7, 2019

  1. Update user baselines (#34842)

    TypeScript Bot authored and weswigham committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    a22ad16 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Cherry-pick PR #34906 into release-3.7 (#35006)

    Component commits:
    dfa4bc0 Use empty object for invalid package json contents instead of undefined Fixes #34726
    
    4d035ba Behave as if package json doesnt exist in case of invalid json in package json
    TypeScript Bot authored and sheetalkamat committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    4d5f30d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Cherry-pick PR #34513 into release-3.7 (#34800)

    Component commits:
    62aad54 Fix a crash when transforming functions in modules.
    When transforming a module declaration and block, parse tree nodes
    contained in the module block have their parent pointers reset due to
    `shouldEmitModuleDeclaration` calling into `isInstantiatedModule`, which
    needs to set parent pointers to operate.
    
    That causes a crash when later transforming any nodes within the module,
    as retrieving their source file in `getSourceFileOfNode` (via
    `getOrCreateEmitNode`) fails, due to their new synthesized parent nodes
    not being in a source file.
    
    This change avoids the issue by using the parse tree node in `ts.ts` to
    decide whether a module declaration should be emitted (i.e. whether the
    module contains values).
    
    This means transformers cannot add values to modules that previously did
    not contain any.
    
    Fixes #34644.
    TypeScript Bot authored and andrewbranch committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    93b1aa3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Fix import type resolution in jsdoc, mark 2 (#35057)

    Fake alias resolution only applies when the import type is followed by a
    qualified name. Otherwise the alias is sufficiently resolved already.
    sandersn committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    dfe2f07 View commit details
    Browse the repository at this point in the history
  2. strip QuestionToken from MethodDeclaration and PropertyDeclaration em…

    …it (#34954)
    
    * strip QuestionToken from MethodDeclartion emit
    
    Fixes: #34953
    
    * test property emit
    ajafff authored and sandersn committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    12e8b08 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Cherry-pick PR #34588 into release-3.7 (#34988)

    Component commits:
    99328e9 Propagate 'undefined' instead of the optional type marker at an optional chain boundary
    
    7aa6eee Merge branch 'master' into fix34579
    # Conflicts:
    #	src/compiler/utilities.ts
    
    61e6765 Update src/compiler/types.ts
    Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
    2 people authored and RyanCavanaugh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2e38783 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7629ec View commit details
    Browse the repository at this point in the history
  3. Fix build script.

    DanielRosenwasser committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    adaacd1 View commit details
    Browse the repository at this point in the history
  4. Cherry-pick PR #35111 into release-3.7 (#35116)

    Component commits:
    6945a72 Support dynamic file names with project root path Fixes #35094
    
    cc30b36 Remove unexpected change
    TypeScript Bot authored and sheetalkamat committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    b37cc6e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Cherry-pick PR #35209 into release-3.7 (#35213)

    Component commits:
    74a6343 Fix the usage of pattern matching for check of hasZeroOrOneAsteriskCharacter Fixes #35171
    
    ffe82c6 Fix error message
    TypeScript Bot authored and sheetalkamat committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    c18d72f View commit details
    Browse the repository at this point in the history
  2. Cherry-pick PR #35198 into release-3.7 (#35240)

    Component commits:
    9c0fab9 Fix crash with Object.defineProperty for imported alias (--allowJs)
    Fixes #35196
    TypeScript Bot authored and sandersn committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    b9d5231 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Cherry-pick PR #35058 into release-3.7 (#35241)

    Component commits:
    8ae5a8c useDefineForClassFields skips emit of ambient properties
    Previously:
    
    ```ts
    class C {
      declare p
    }
    ```
    
    would incorrectly emit
    
    ```js
    class C {
        constructor() {
            Object.defineProperty(this, "p", {
                enumerable: true,
                configurable: true,
                writable: true,
                value: void 0
            });
        }
    }
    ```
    
    when useDefineForClassFields was turned on (for targets <ESNext).
    
    0ec9c04 Fix bug for ESNext as well
    This moves the check earlier in the pipeline.
    
    e1aa034 update baselines
    TypeScript Bot authored and DanielRosenwasser committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    d5bcb6f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Cherry-pick PR #34987 into release-3.7 (#35303)

    Component commits:
    5810765 Emit defineProperty calls before param prop assignments
    Note that I restricted this to --useDefineForClassFields is true.
    Nothing changes when it's off. I think this is the correct fix for a
    patch release.
    
    However, in principal there's nothing wrong with moving parameter
    property initialisation after property declaration initialisation. It
    would be Extremely Bad and Wrong to rely on this working:
    
    ```ts
    class C {
      p = this.q // what is q?
      constructor(public q: number) { }
    }
    ```
    
    But today it does, and probably somebody relies on it without knowing.
    
    ec79590 Put parameter property initialiser into defineProperty's value
    
    be86355 Merge branch 'master' into fix-defineProperty-parameter-property-emit
    
    8ff59b9 Combine ES5/ESNext into one test
    TypeScript Bot authored and sandersn committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    c021b28 View commit details
    Browse the repository at this point in the history
  2. Update LKG.

    DanielRosenwasser committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    a8b63ef View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Update user baselines (#35302)

    TypeScript Bot authored and weswigham committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    9bf4e3a View commit details
    Browse the repository at this point in the history
  2. Update user baselines (#35337)

    TypeScript Bot authored and weswigham committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    38a496a View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Cherry-pick PR #35366 into release-3.7 (#35368)

    Component commits:
    eeacbbf Handle when output file would be in subFolder specified by outDir/declarationDir Fixes #35328
    TypeScript Bot authored and sheetalkamat committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    c4d6cec View commit details
    Browse the repository at this point in the history
  2. Cherry-pick PR #35335 into release-3.7 (#35367)

    Component commits:
    c44de23 Fix compileOnSaveEmit when using source of project reference redirect with --out Fixes #35226
    
    522efb4 Fix typo
    TypeScript Bot authored and sheetalkamat committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    41d1ce6 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Fix getTypeFromJSDocValueReference

    When using `{import('./b').FOO}` which is defined as a string literal,
    `valueType` doesn't have a `symbol`.  Leave it for the fallback value
    for now.
    
    This was exposed in 8223c07.
    
    Fixes #34869.
    elibarzilay committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    e65ce53 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Update LKG.

    DanielRosenwasser committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    79facc0 View commit details
    Browse the repository at this point in the history
Loading