Skip to content

docs: default dataTransferMode is streaming, not bulk #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

docs: default dataTransferMode is streaming, not bulk #2377

merged 4 commits into from
Jun 5, 2025

Conversation

operte
Copy link
Contributor

@operte operte commented May 23, 2025 •
edited
Loading

Related Issues/PRs

What changes are proposed in this pull request?

The docs say that the default dataTransferMode is bulk but it is actually set to streaming. We just found this out over a long debugging session at work.

I saw that the default mode was recently changed to streaming by #2088 so I assume this was purposeful. Therefore I decided to change the docs to be in accordance to the current default, instead of reverting the default to bulk.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@operte operte requested a review from svotaw as a code owner May 23, 2025 12:24
@operte operte changed the title Change default dataTransferMode to bulk fix: Change default dataTransferMode to bulk May 24, 2025
@operte operte changed the title fix: Change default dataTransferMode to bulk revert: default dataTransferMode to bulk May 24, 2025
@operte operte changed the title revert: default dataTransferMode to bulk docs: default dataTransferMode is streaming, not bulk May 28, 2025
@operte operte requested a review from mhamilton723 as a code owner May 28, 2025 15:40
@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)		 Terminology Spelling and grammar Clarity
(Readability)
✅ docs/Explore Algorithms/LightGBM/Overview.md 93 100 96 83

More information about Acrolinx

@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)		 Terminology Spelling and grammar Clarity
(Readability)
✅ docs/Explore Algorithms/LightGBM/Overview.md 93 100 96 83

More information about Acrolinx

@operte
Copy link
Contributor Author

operte commented Jun 2, 2025

@microsoft-github-policy-service agree company="Adyen"

@operte operte force-pushed the operte-default-datatransfermode-bulk branch from 440042b to a60a8e1 Compare June 2, 2025 07:52
@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)		 Terminology Spelling and grammar Clarity
(Readability)
✅ docs/Explore Algorithms/LightGBM/Overview.md 93 100 96 83

More information about Acrolinx

@acrolinxatmsft1
Copy link

Acrolinx Scorecards

A minimum total score of 80 is required.

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.

Article Total score
(Required: 80)		 Terminology Spelling and grammar Clarity
(Readability)
✅ docs/Explore Algorithms/LightGBM/Overview.md 93 100 96 83

More information about Acrolinx

@operte
Copy link
Contributor Author

operte commented Jun 3, 2025

Hey @mhamilton723 , is there anything missing to start a review of this MR? 🙏 :)

@mhamilton723 mhamilton723 merged commit ffa0383 into microsoft:master Jun 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svotaw svotaw Awaiting requested review from svotaw svotaw is a code owner

@mhamilton723 mhamilton723 Awaiting requested review from mhamilton723 mhamilton723 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@operte @acrolinxatmsft1 @mhamilton723