chore: Removing unnecessary logs #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are putting all request contents into logs, which just add unnecessary noise in the logs and we add the same message twice. I am ensuring that message is only added for debug.
mhamilton723
previously approved these changes
Mar 30, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2359 +/- ##
=======================================
Coverage 81.17% 81.18%
=======================================
Files 331 331
Lines 17177 17179 +2
Branches 1539 1550 +11
=======================================
+ Hits 13943 13946 +3
+ Misses 3234 3233 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are putting all request contents into logs, which just add unnecessary noise in the logs and we add the same message twice. I am ensuring that message is only added for debug.
What changes are proposed in this pull request?
Reduce log by not logging entire messages twice
How is this patch tested?
Just removing logs
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?