[WIP] Phi3poc #2301
Merged
[WIP] Phi3poc #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2301 +/- ##
==========================================
- Coverage 84.67% 84.61% -0.07%
==========================================
Files 331 331
Lines 17179 17179
Branches 1550 1550
==========================================
- Hits 14547 14536 -11
- Misses 2632 2643 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
mhamilton723
reviewed
Jan 2, 2025
| typeConverter=TypeConverters.toString, | ||
| ) | ||
| modelParam = Param(Params._dummy(), "modelParam", "Model Parameters") | ||
| modelConfig = Param(Params._dummy(), "modelConfig", "Model configuration") |
There was a problem hiding this comment.
Maybe explain difference between model config and other params (you can just link to other docs if easier)
mhamilton723
reviewed
Jan 2, 2025
core/src/main/python/synapse/ml/llm/HuggingFaceCausallmTransform.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
previously approved these changes
Apr 10, 2025
core/src/test/scala/com/microsoft/azure/synapse/ml/nbtest/DatabricksUtilities.scala
Outdated
Show resolved
Hide resolved
…bricksUtilities.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.