Skip to content

<generator>: Don't include <ranges> #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2024
Merged

<generator>: Don't include <ranges> #4620

merged 1 commit into from
May 10, 2024

Conversation

JMazurkiewicz
Copy link
Contributor

This improves inclusion time of <generator>.

generator.cpp:

#include <generator>

Before:

PS D:\stl-playground> cl /std:c++latest /Bt /nologo .\generator.cpp /Zs
generator.cpp
time(C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.40.33721\bin\HostX64\x64\c1xx.dll)=0.514s

After:

PS D:\stl-playground> cl /std:c++latest /Bt /nologo .\generator.cpp /Zs
generator.cpp
time(C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.40.33721\bin\HostX64\x64\c1xx.dll)=0.257s

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner April 23, 2024 14:46
@StephanTLavavej StephanTLavavej added throughput Must compile faster generator C++23 generator labels Apr 23, 2024
@StephanTLavavej
Copy link
Member

/azp run STL-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@frederick-vs-ja frederick-vs-ja mentioned this pull request Apr 27, 2024
Merged
@StephanTLavavej StephanTLavavej removed their assignment Apr 28, 2024
@StephanTLavavej StephanTLavavej merged commit c2b0579 into microsoft:feature/generator May 10, 2024
@StephanTLavavej
Copy link
Member

Thanks for noticing this significant throughput improvement! 🚀 😻

@JMazurkiewicz JMazurkiewicz deleted the generator/includes branch May 13, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
generator C++23 generator throughput Must compile faster
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter