Skip to content

ZI: clear history when reusing scope #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2017
Merged

ZI: clear history when reusing scope #547

merged 2 commits into from
Mar 30, 2017

Conversation

jenshnielsen
Copy link
Collaborator

The issue with changing number of segments seems to be that old data may be returned along with the new data. Clear data to ensure that this can not happen.

WilliamHPNielsen
WilliamHPNielsen approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the need to clear history documented?

@WilliamHPNielsen WilliamHPNielsen merged commit b44ceae into microsoft:master Mar 30, 2017
giulioungaretti pushed a commit that referenced this pull request Mar 30, 2017
Generated gh-pages for commit b44ceae
96e4afe 
Merge: a957e51 45c389f
Author: William H.P. Nielsen <whpn@mailbox.org>

    Merge pull request #547 from jenshnielsen/zi_clear_history
@jenshnielsen jenshnielsen deleted the zi_clear_history branch March 30, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@WilliamHPNielsen WilliamHPNielsen WilliamHPNielsen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshnielsen @WilliamHPNielsen @jana-d