feat: narrow for non totally ordered types #986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #900.
Supersedes #917.
In the original overload,
((t < T{}) != (u < U{}))
is only ever reached whenis_different_signedness
istrue
, which is only evertrue
for arithmetic types because the same applies tostd::is_signed<T>::value
whichis_different_signedness
is initialized from. So we usestd::is_arithmetic<T>::value
to add an overload.