feat: narrow for non totally ordered types #917
Conversation
|
Maintainers' call: Thanks for the feature suggestion. Because the GSL design and feature set is owned by the C++ Core Guidelines, this is just an implementation and we follow what the Guidelines specify. So we defer all feature suggestions by opening the issue in the Guidelines repo, and in the meantime we'll close the one here which can then be reopened later when there is guidance to follow from the Guidelines' making a design/feature change. Please reactivate this one when there's a conclusion. |
Here's the conclusion: isocpp/CppCoreGuidelines#1726 (comment). Can this PR be reactivated? It's not clear to me whether this PR makes |
|
Yes, please reactivate this. Unfortunately, you'll need to rebase your changes and post a new PR. When we migrated the primary branch from |
Resolves #900.
In the original overload,
((t < T{}) != (u < U{}))is only ever reached whenis_different_signednessistrue, which is only evertruefor arithmetic types because the same applies tostd::is_signed<T>::valuewhichis_different_signednessis initialized from. So we usestd::is_arithmetic<T>::valueto add an overload.