Skip to content

Added support for setting randomSeed & randomValue properties for transcript testing #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

Added support for setting randomSeed & randomValue properties for transcript testing #2209

merged 2 commits into from
Dec 3, 2020

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Dec 3, 2020 •
edited
Loading

Satisfies the P0 requirements of #2181

image

corinagum
corinagum approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano tonyanziano merged commit 1a9973e into main Dec 3, 2020
@tonyanziano tonyanziano deleted the toanzian/feat/transcript-testing branch December 3, 2020 19:34
@tonyanziano tonyanziano mentioned this pull request Dec 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyanziano @corinagum