Skip to content

Locked eslint-plugin-import@2.20.0 to avoid unecessary import linting… #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Locked eslint-plugin-import@2.20.0 to avoid unecessary import linting… #2081

merged 1 commit into from
Feb 13, 2020

Conversation

tonyanziano
Copy link
Contributor

… changes.

Without this change, regenerating the package-lock would bump this package to 2.20.1 which introduces new linting requirements for import order which results in us needing touch over 400 files to satisfy the linter.

@coveralls
Copy link

coveralls commented Feb 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 68.031% when pulling e42a8c9 on toanzian/linting into 50009de on master.

@tonyanziano tonyanziano merged commit 8ca1397 into master Feb 13, 2020
@tonyanziano tonyanziano deleted the toanzian/linting branch February 13, 2020 22:04
@tonyanziano tonyanziano mentioned this pull request Feb 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@tdurnford tdurnford Awaiting requested review from tdurnford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @srinaath