Skip to content

Removed bubble user background color. Leave it to default option #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2020
Merged

Removed bubble user background color. Leave it to default option #2067

merged 2 commits into from
Jan 29, 2020

Conversation

srinaath
Copy link
Contributor

Revert the bubble background to use default color from webchat

Removed bubble user background color. Leave it to default option
768faea 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
updated changelog
3a8bee5 
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.574% when pulling 3a8bee5 on srravich/bugfix/1929-attachment into e200c7f on master.

tonyanziano
tonyanziano approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srinaath
Copy link
Contributor Author

BEFORE:
before-filename-hidden

AFTER:
after-background-remove

@srinaath srinaath merged commit c5f2ff4 into master Jan 29, 2020
@tonyanziano tonyanziano deleted the srravich/bugfix/1929-attachment branch January 29, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten Awaiting requested review from cwhitten

@compulim compulim Awaiting requested review from compulim

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@corinagum corinagum Awaiting requested review from corinagum

@tdurnford tdurnford Awaiting requested review from tdurnford

1 more reviewer

@tonyanziano tonyanziano tonyanziano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srinaath @coveralls @tonyanziano