Skip to content

Fix URI creation from path #3467

@aeschli

Description

@aeschli

In 1.26 we discovered that several extensions call the 'vscode.openFolder' command with invalid file URIs:

ms-dynamics-smb.al/out/src/services/bootstrapService.js
  57,45:             vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir));

When creating a URI from a file path, always use vscode.URI.file(path), e.g vscode.URI.file('c:\\test')
Use vscode.URI.parse(uriString) when the input string is in the form scheme://authority/path

See microsoft/vscode#57267 for more information or for questions.

  • AL Extension Version:
  • Server Version:

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugProduct bugships-in-future-updateThe issue is fixed in our 'master' branch and will ship in the next PREVIEW release

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions