Update detours vcpkg to use prior version #5601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Jul 21, 2025
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Jul 21, 2025
## Change Starting with the time that the UndockedRegFreeWinRT change was introduced and working backward through commits, I found the equivalent one (only whitespace changes are present, probably due to auto-formatting). This change uses the existing overlay infrastructure to update the detours port to that commit.
JohnMcPMS
added a commit
that referenced
this pull request
Jul 21, 2025
Cherry pick #5601 ## Change Starting with the time that the UndockedRegFreeWinRT change was introduced and working backward through commits, I found the equivalent one (only whitespace changes are present, probably due to auto-formatting). This change uses the existing overlay infrastructure to update the detours port to that commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5590
Issue
Due to internal security requirements, we moved to a vcpkg for detours. Due to it coming indirectly through UndockedRegFreeWinRT, we didn't have the exact commit. Thus, we used the latest (only) vcpkg version available.
This caused crashes in the PowerShell module on ARM64, as the only detours release is prior to better support for ARM64. Our prerelease automated validations did not catch it, as we don't have ARM64 runners. We will investigate adding them to prevent a future issue like this.
Change
Starting with the time that the UndockedRegFreeWinRT change was introduced and working backward through commits, I found the equivalent one (only whitespace changes are present, probably due to auto-formatting). This change uses the existing overlay infrastructure to update the detours port to that commit.
Validation
I was able to repro on an ARM64 device. Building the dll in the appropriate configuration with this change was successful in resolving the issue in the module.
Microsoft Reviewers: Open in CodeFlow