Add missing compilation flags for vcpkg ports #5587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5567 didn't actually fix the crash we were seeing.
The actual cause of the crash seems to be that I missed adding some compilation flags that we had added to the
.vcxproj
for cpprestsdk when I moved the dependencies to vcpkg (which does not use the.vcxproj
). Specifically, I didn't set a flag to compile it without async support, so the library used async but winget wasn't prepared for that.This PR adds the missing compilation flags for all ports, taken from the project files before the migration to vcpkg. I added the flags to the triplet files (conditionally) so that it applies the same regardless of whether a port comes from the official registry or a local overlay.
I noticed that for
libyaml
andjsoncpp
I missed the flags to prepare for fuzzing, so I added a new triplet for those.This PR also updates the pipeline to publish the compilation logs from vcpkg for easier debugging in the future.
Microsoft Reviewers: Open in CodeFlow