Repair Repair-WinGetPackageManager #5568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yao-msft
approved these changes
Jul 3, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@JohnMcPMS do you know/remember what the actual issue was with |
|
I believe the original issue is dotnet/runtime#26612 For compatibility reason, it's by design to not break legacy code. |
florelis
added a commit
to florelis/winget-cli
that referenced
this pull request
Jul 4, 2025
`Repair-WinGetPackageManager` is failing to install winget in some Win10 systems. The issue seems come from microsoft#5517 and be caused because in some cases we fail to mark any one architecture as the right one to use for dependencies. This PR is a partial revert of microsoft#5517 to add the previous logic as a fallback. May fix microsoft#5559 (but I haven't set up an environment to test it...) ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5568)
florelis
added a commit
that referenced
this pull request
Jul 7, 2025
This is a cherry-pick of #5570, #5568 and #5567 to the v1.11 branch. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair-WinGetPackageManageris failing to install winget in some Win10 systems. The issue seems come from #5517 and be caused because in some cases we fail to mark any one architecture as the right one to use for dependencies. This PR is a partial revert of #5517 to add the previous logic as a fallback.May fix #5559 (but I haven't set up an environment to test it...)
Microsoft Reviewers: Open in CodeFlow