-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use cpprestsdk v2.10.18 #5567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use cpprestsdk v2.10.18 #5567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yao-msft
approved these changes
Jul 3, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
florelis
added a commit
to florelis/winget-cli
that referenced
this pull request
Jul 4, 2025
We are seeing a crash coming from cpprestsdk, which happened after moving to use vcpkg dependencies and updating to v2.10.19. This reverts to the version we knew to be good, but it may be that the actual issue is not from cpprestsdk but from one of the patches from vcpkg. We consume cpprestsdk from a local port overlay that we use to be able to patch it with support for certificate pinning, so the main change is to the script that creates the port overlay. The script makes a copy of the port from the official registry; and this PR updates it so that it can fetch a version from an older commit and not just the latest. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5567)
florelis
added a commit
that referenced
this pull request
Jul 7, 2025
This is a cherry-pick of #5570, #5568 and #5567 to the v1.11 branch. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5571)
florelis
added a commit
that referenced
this pull request
Jul 14, 2025
#5567 didn't actually fix the crash we were seeing. The actual cause of the crash seems to be that I missed adding some compilation flags that we had added to the `.vcxproj` for cpprestsdk when I moved the dependencies to vcpkg (which does not use the `.vcxproj`). Specifically, I didn't set a flag to compile it without async support, so the library used async but winget wasn't prepared for that. This PR adds the missing compilation flags for all ports, taken from the project files before the migration to vcpkg. I added the flags to the triplet files (conditionally) so that it applies the same regardless of whether a port comes from the official registry or a local overlay. I noticed that for `libyaml` and `jsoncpp` I missed the flags to prepare for fuzzing, so I added a new triplet for those. This PR also updates the pipeline to publish the compilation logs from vcpkg for easier debugging in the future. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5587)
florelis
added a commit
to florelis/winget-cli
that referenced
this pull request
Jul 14, 2025
microsoft#5567 didn't actually fix the crash we were seeing. The actual cause of the crash seems to be that I missed adding some compilation flags that we had added to the `.vcxproj` for cpprestsdk when I moved the dependencies to vcpkg (which does not use the `.vcxproj`). Specifically, I didn't set a flag to compile it without async support, so the library used async but winget wasn't prepared for that. This PR adds the missing compilation flags for all ports, taken from the project files before the migration to vcpkg. I added the flags to the triplet files (conditionally) so that it applies the same regardless of whether a port comes from the official registry or a local overlay. I noticed that for `libyaml` and `jsoncpp` I missed the flags to prepare for fuzzing, so I added a new triplet for those. This PR also updates the pipeline to publish the compilation logs from vcpkg for easier debugging in the future. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5587)
florelis
added a commit
that referenced
this pull request
Jul 14, 2025
…5589) #5567 didn't actually fix the crash we were seeing. The actual cause of the crash seems to be that I missed adding some compilation flags that we had added to the `.vcxproj` for cpprestsdk when I moved the dependencies to vcpkg (which does not use the `.vcxproj`). Specifically, I didn't set a flag to compile it without async support, so the library used async but winget wasn't prepared for that. This PR adds the missing compilation flags for all ports, taken from the project files before the migration to vcpkg. I added the flags to the triplet files (conditionally) so that it applies the same regardless of whether a port comes from the official registry or a local overlay. I noticed that for `libyaml` and `jsoncpp` I missed the flags to prepare for fuzzing, so I added a new triplet for those. This PR also updates the pipeline to publish the compilation logs from vcpkg for easier debugging in the future. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a crash coming from cpprestsdk, which happened after moving to use vcpkg dependencies and updating to v2.10.19. This reverts to the version we knew to be good, but it may be that the actual issue is not from cpprestsdk but from one of the patches from vcpkg.
We consume cpprestsdk from a local port overlay that we use to be able to patch it with support for certificate pinning, so the main change is to the script that creates the port overlay. The script makes a copy of the port from the official registry; and this PR updates it so that it can fetch a version from an older commit and not just the latest.
Microsoft Reviewers: Open in CodeFlow