Make dsc3 and export experimentals stable #5487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
May 28, 2025
| @@ -354,25 +354,3 @@ You can enable the feature as shown below. | |||
| "resume": true | |||
| }, | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
Not related to your change, but I noticed that Settings.md is outdated because it lists resume but not fonts
| @@ -294,21 +294,6 @@ | |||
| "type": "boolean", | |||
| "default": false | |||
| }, | |||
| "configuration03": { | |||
There was a problem hiding this comment.
I dream of the day we finally get around to versioning this file...
I wonder if we could publish it as an artifact for each release, and have the schema URI point to the release instead of the source code. Or at least point to a release branch
| { | ||
| set.Environment().ProcessorIdentifier(ConfigurationRemoting::ToString(ConfigurationRemoting::ProcessorEngine::DSCv3)); | ||
| } | ||
| set.Environment().ProcessorIdentifier(ConfigurationRemoting::ToString(ConfigurationRemoting::ProcessorEngine::DSCv3)); |
There was a problem hiding this comment.
If v3 is the default now, is there anything specific to v2 that need to be removed?
| @@ -79,10 +75,6 @@ namespace AppInstaller::Settings | |||
| return ExperimentalFeature{ "Direct MSI Installation", "directMSI", "https://aka.ms/winget-settings", Feature::DirectMSI }; | |||
| case Feature::Resume: | |||
| return ExperimentalFeature{ "Resume", "resume", "https://aka.ms/winget-settings", Feature::Resume }; | |||
| case Feature::ConfigurationDSCv3: | |||
| return ExperimentalFeature{ "Support for DSC v3", "dsc3", "https://aka.ms/winget-settings", Feature::ConfigurationDSCv3 }; | |||
There was a problem hiding this comment.
Have we, or will we ever used a link that wasn't https://aka.ms/winget-settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Move the
dsc3andconfigureExportfeatures to stable.Microsoft Reviewers: Open in CodeFlow