Add support for DSCv3 in configuration PowerShell modules #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
May 21, 2025
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| // Forcibly set the target and supported platforms due to the internal build setup. | |||
| // Keep in sync with project versions. | |||
| [assembly: TargetPlatform("Windows10.0.22000.0")] | |||
| [assembly: TargetPlatform("Windows10.0.26100.0")] | |||
There was a problem hiding this comment.
I feel like there was a reason that I didn't update that... but now I'm not remembering it.
|
|
||
| await installDSCv3.InvokeAsync(); | ||
|
|
||
| if (installDSCv3.HadErrors) |
There was a problem hiding this comment.
Install-WinGetPackage does not produce an error on failed install. The result object must be inspected.
I'm not sure of the "correct" PowerShell design, but maybe one of:
- A new cmdlet like
Validate-WinGetPackageInstallthat throws if the install failed - A new parameter like
-ThrowOnFailure - A breaking change to throw on failure (maybe with a parameter to not)
There was a problem hiding this comment.
I can change the script to inspect the result object.
JohnMcPMS
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow