Fix debug build with latest VS version #5461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as resolved.
This comment was marked as resolved.
JohnMcPMS
reviewed
May 19, 2025
|
What is warning 5321? I can't find any docs online mentioning it |
I searched online and cannot find it too when I encountered it. The closest I found is https://github.com/microsoft/STL/wiki/Changelog/c5aa92bec22b0d09c41282a79437855e9b269ebf Which basically says: for cross platform reasons, don't use u8"\xffff" like literals since it's not supported in other platforms. But since our project is Windows only, I think we can safely ignore it. |
JohnMcPMS
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The u8"" string literal causes a new compiler warning 5321 with latest update, disable it in the project level.
Also updated fuzzing path, again.
Microsoft Reviewers: Open in CodeFlow