Skip to content

Fix DynamicProcessor crash when working on individual units without a set #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Mar 18, 2025

Added unit test. Manually validated as well.

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner March 18, 2025 01:44
JohnMcPMS
JohnMcPMS previously approved these changes Mar 18, 2025
@JohnMcPMS JohnMcPMS dismissed their stale review March 18, 2025 18:00

Missed something

@JohnMcPMS
Copy link
Member

There could still be attempts to use m_configurationSet when CreateSetProcessorForIntegrityLevel wants to create a Security::IntegrityLevel::High processor. It calls Serialize* and both of those functions use it.

I'm not sure what you can really do with that case though as the security design doesn't really allow for arbitrary unit processing in High IL. So it should probably just fail (not AV of course).

@yao-msft yao-msft merged commit 86fda9f into microsoft:master Mar 19, 2025
9 checks passed
@yao-msft yao-msft deleted the exportgetfailure branch March 19, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants