Dscv3 package resource #5395
Dscv3 package resource #5395
Conversation
| <value>Indicates whether to accept agreements for package installs.</value> | ||
| </data> | ||
| <data name="CorrelationArgumentDescription" xml:space="preserve"> | ||
| <value>An unused argument for logging</value> |
There was a problem hiding this comment.
Is this intended to be in product code?
There was a problem hiding this comment.
I did consider making it test specific, but it seems reasonable to allow it to be passed in by anyone so that log files can be tagged.
There was a problem hiding this comment.
nit: maybe a description like "hidden argument" would be better than "unused"
| { | ||
| return MatchType::Exact; | ||
| } | ||
| else if (lowerValue == "equals""case""insensitive") |
There was a problem hiding this comment.
Is it for preventing spelling check errors?
There was a problem hiding this comment.
Yes, the spell checker is ok with this and C rules means that this is the same as "equalscaseinsensitive".
|
|
||
| if (package.Scope != Manifest::ScopeEnum::Unknown) | ||
| { | ||
| output.Scope(ConvertScope(Manifest::ScopeToString(package.Scope), true)); |
There was a problem hiding this comment.
If we export Scope, during apply, will it be enforced during installer selection and may cause failures? i.e. we have many installers that do not specify scope.
There was a problem hiding this comment.
Good point; I think we would need to support the "OrUnknown" variants for this to work as simply as it is now. Alternately, we would need to check that the current scope is an available installer or track scope intent as we do for some other values.
There was a problem hiding this comment.
Yeah, the other thing (for export) besides scope that could be a challenge is the install location.
Change
Add a new DSC v3 resource:
package. This largely follows the design of the v2 resource, but uses the v3 paradigm for existence.Other minor changes:
StdErrLoggerand attaches it during resource execution. This currently writes all logs atErroror higher tostd::cerr, allowingdsc.exeto receive (and pass on) failure information.ManifestComparatorto common for re-use.Validation
Added E2E tests to invoke the package resource in a variety of situations.
Microsoft Reviewers: Open in CodeFlow