Skip to content

Fix it twice #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Fix it twice #5381

merged 1 commit into from
Apr 11, 2025

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Apr 11, 2025 •
edited by microsoft-github-policy-service bot
Loading

Fixes #5365

Change

Fix the issue in two ways:

  1. Only use - 1 if supportedConcurrentThreads is greater than 1.
  2. Swap the order of setting min and max thread counts on the pool so that setting the minimum thread count to 1 overrides a "bad" allowed thread count of 0 (there are better ways to not do something than creating a thread pool that isn't allowed any threads).
Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner April 11, 2025 18:49
@JohnMcPMS JohnMcPMS merged commit dabd0e0 into microsoft:master Apr 11, 2025
9 checks passed
@JohnMcPMS JohnMcPMS deleted the min-download-threads branch April 11, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COM Install/Download thread logic issue
2 participants
@JohnMcPMS @yao-msft