-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fixes for pipeline stability #5359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -50,7 +50,7 @@ | |||
"Microsoft.VisualStudio.Component.VC.ASAN", | |||
"Microsoft.VisualStudio.Component.Vcpkg", | |||
"Microsoft.VisualStudio.Component.Windows10SDK.19041", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep 19041?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, I don't see anything using it in this solution. I can remove it in another PR to prevent the need to rebuild this one.
@@ -186,7 +186,7 @@ jobs: | |||
Microsoft.Management.Deployment\Microsoft.Management.Deployment.winmd | |||
WindowsPackageManager\WindowsPackageManager.dll | |||
UndockedRegFreeWinRT\winrtact.dll | |||
TargetFolder: $(buildOutDirAnyCpu)\PowerShell\Microsoft.WinGet.Client\net8.0-windows10.0.22000.0\SharedDependencies\$(BuildPlatform) | |||
TargetFolder: $(buildOutDirAnyCpu)\PowerShell\Microsoft.WinGet.Client\net8.0-windows10.0.26100.0\SharedDependencies\$(BuildPlatform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be fun to update in the internal pipeline...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[fingers in ears] la la la la, I can't hear you
Issue
Due to an issue with dsc.exe creating child processes (which after much investigation appears to be a race that only occurs on older OS versions), we get arbitrary failures.
We also occasionally get spurious failures of configuration tests.
Change
Move to
windows-2025
to avoid the process creation failures from dsc.exe.Move to Windows 11 SDK 26100 as 22000 is not installed by default on
windows-2025
.Flush output at the end of a configuration unit info dump.
Add missing interface to manifest (@yao-msft was right).
Use
pwsh
task at least once to ensure that it is present.Microsoft Reviewers: Open in CodeFlow