Fix logging channel setting #5261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Feb 28, 2025
yao-msft
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The user setting to control the logging channels was no longer being respected after a previous change to enable all channels during initialization (and to send the initialization logs to the debug stream).
Change
EnableChannelfor logging has always been semantically "add the given channel(s) to the list of enabled channels".Every place that we were calling
EnableChannelwas really semantically wanting to set the list of enabled channels rather than add to it.This change creates a new function
SetEnabledChannelsthat behaves that way; it simply sets the enabled channel mask to the given value. All callers ofEnableChannelwere changed to use this new function.Microsoft Reviewers: Open in CodeFlow