Experimental support for DSC v3 processing #5252
Conversation
…part of command line to elevated server
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ee function doesn't dispose the temporary key that it creates.
|
|
||
| if (dscExecutablePath.empty()) | ||
| { | ||
| dscExecutablePath = m_dynamicFactory->Lookup(ToHString(PropertyName::FoundDscExecutablePath)); |
There was a problem hiding this comment.
Does the FoundDscExecutablePath always exist?
| ProcessorEngine result = ProcessorEngine::Unknown; | ||
|
|
||
| winrt::hstring processorIdentifier = set.Environment().ProcessorIdentifier(); | ||
| if (processorIdentifier.empty() || processorIdentifier == L"pwsh") |
There was a problem hiding this comment.
Do we want to be more permissive by doing case insensitive checks?
There was a problem hiding this comment.
nit: btw, the tests in ConfigurationSetAuthoringTests.cs used dsc3 as ProcessorIdentifier, we may want to update those to avoid confusion.
|
@JohnMcPMS, nice work! I really love seeing the content coming and WinGet's integration with DSC v3. Perhaps a tiny tiny remark. I can see that you've implemented a workaround in the azure-pipelines to install |
I will move to using the fully released build in my next change after it becomes available. That will likely be this week. |
Change
Adds experimental support for DSC v3 processing of configurations. When enabled, one can use DSC v3 instead of PowerShell DSC v2 by setting their processor to
dscv3for the configuration like:This is currently on-par with DSC v2 in terms of functionality, except for 2 things:
9PCX3HX4HZ0Z) if installed. Otherwise, you can specify the--processor-pathto dsc.exe.Also makes 0.3 schema not experimental and fixes configuration history for environments.
Validation
Added unit and E2E tests.
Microsoft Reviewers: Open in CodeFlow