Skip to content

Standardize how arguments are used in resource strings #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

Standardize how arguments are used in resource strings #2737

merged 1 commit into from
Dec 2, 2022

Conversation

florelis
Copy link
Member

@florelis florelis commented Dec 2, 2022 •
edited by ghost
Loading

This standardizes how we use arguments in resource strings and adds comments so that the localization team does not change them. We had different styles, like "--argument", argument, --argument. This standardizes all to --argument for consistency.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner December 2, 2022 22:13
yao-msft
yao-msft approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@florelis florelis merged commit 114ce1e into microsoft:master Dec 2, 2022
@florelis florelis deleted the resourceConsistency branch December 2, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florelis @yao-msft