Make the warning error, and restore previous props so we attempt to run #15078
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen user suppresses
nohwnd
commented
May 29, 2025
src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.nuspec
Outdated
Show resolved
Hide resolved
drognanar
reviewed
May 29, 2025
…thub.com/nohwnd/vstest into error-on-unsupported-tfms-and-add-native
drognanar
approved these changes
May 29, 2025
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Jun 3, 2025
…un (microsoft#15078) * Make the warning error, and restore previous props so we get errors when user suppresses * Update src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.nuspec * Correct file count, because we are adding more props * Wrong edit
nohwnd
added a commit
that referenced
this pull request
Jun 5, 2025
* Warning on unsupported tfms (#15072) * Add warning when restoring old TFM * revert * Revert "revert" This reverts commit 81c7638. * Make the warning error, and restore previous props so we attempt to run (#15078) * Make the warning error, and restore previous props so we get errors when user suppresses * Update src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.nuspec * Correct file count, because we are adding more props * Wrong edit
This was referenced Jul 21, 2025
Closed
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add targets so we don't fallback on package restore on unsupported tfms, and don't end up restoring wrong tfm by accident. Add props back in so we attempt to run via dotnet test.
Related issue
Related #15069