Description

VSTest requires IncludeSourceRevisionInInformationalVersion to be set to false in order to build successfully with -ci, however this is only specified in the build YML. Instead you should set this in your build targets to avoid folks having to know to set it. This broke the VMR / SourceBuild when the ProductVersion validation was recently added.

Steps to reproduce

See dotnet/sdk#42157 (comment)

Expected behavior

Successful build. No need to specify additional arguments.

Actual behavior

Build fails with

      At D:\a\_work\1\vmr\src\vstest\eng\verify-nupkgs.ps1:292 char:13
      +             throw "$_ contains '+' in the ProductVersion $($_.Version ...
      +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          + CategoryInfo          : OperationStopped: (vstest.console....AAgent in AzDO.:String) [], RuntimeException
          + FullyQualifiedErrorId : vstest.console.dll contains '+' in the ProductVersion 17.12.0-preview-24373-01+e053d5b5b

Diagnostic logs

Binlog: source-inner-build-vstest.zip

Environment

See dotnet/sdk#42157 (comment)