-
Notifications
You must be signed in to change notification settings - Fork 341
Closed
Description
Description
VSTest should be using logger instead of Console.WriteLine. I.e.:
Console.WriteLine(Resources.TestRunningSummary, this.TestFileFullPath, this.VSTestFramework); |
Console.WriteLine(Resources.UpdateTestSdkForCollectingCodeCoverage); |
This is causing that in some cases output gets lost.
Steps to reproduce
- Clone https://github.com/dotnet/iot/
- Replace following ("Test") task https://github.com/dotnet/iot/blob/a5a53b5a3a287638df0176c483fcb1f3b2fef7f0/build.proj#L59 with
<Target Name="Test">
<ItemGroup>
<UnitTestProjects Include="$(MSBuildThisFileDirectory)src\devices\**\*.Tests.csproj" />
</ItemGroup>
<MSBuild Projects="@(UnitTestProjects)" Targets="VSTest"
ContinueOnError="ErrorAndContinue" />
<Error Condition="$(MSBuildLastTaskResult) != 'true'"
Text="Unit tests failed. Please check the detailed log to find out which ones failed." />
</Target>
Replacing will not be needed once linked PR is merged
- Run build.cmd/build.sh (in the root directory)
If any property is passed to MSBuild task then output gets printed (because of luck it gets run on master node where Console.WriteLine works correctly)
Expected behavior
Test output is displayed
Actual behavior
Build fails but no errors get printed
nohwnd, felixscheffer, pgrawehr and raffaeler
Metadata
Metadata
Assignees
Labels
No labels