Skip to content

Fix tabbing in quick pick #32265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2017
Merged

Fix tabbing in quick pick #32265

merged 2 commits into from
Aug 11, 2017

Conversation

Lixire
Copy link
Contributor

@Lixire Lixire commented Aug 11, 2017

Fixes #31835 and #31836

  • makes the tree view untabbable in order to get to the actionbar item in one tab
  • adds a listener for arrow keys and page up/down to focus next/previous entries from a tabbed actionbar state

@Lixire Lixire added terminal General terminal issues that don't fall under another label quick-pick Quick-pick widget issues labels Aug 11, 2017
@Lixire Lixire added this to the August 2017 milestone Aug 11, 2017
@Lixire Lixire requested a review from roblourens August 11, 2017 00:59
@mention-bot
Copy link

@Lixire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

@roblourens roblourens merged commit f1a3bc4 into master Aug 11, 2017
@bpasero
Copy link
Member

bpasero commented Aug 11, 2017 •
edited
Loading

@Lixire @roblourens please be very careful with these kind of changes, todays insider broke quick navigate due to it. I reverted the changes and triggered new builds.

The bug manifests like this:

  • press Ctrl+Tab
  • release keys
  • quick navigate is not triggered basically disabling this feature altogether

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
quick-pick Quick-pick widget issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.

Terminal Switcher: Rename should be reachable with first tab
5 participants
@Lixire @mention-bot @bpasero @roblourens @msftclas