Skip to content

Conversation

anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Aug 25, 2025

Resolves: #209003

With only #198116 and #240296 remaining under terminal-sticky-scroll label, shall we have default to true, and have more folks in stable try out.

@anthonykim1 anthonykim1 added this to the August 2025 milestone Aug 25, 2025
@anthonykim1 anthonykim1 self-assigned this Aug 25, 2025
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to remove the product import to fix compile

@anthonykim1 anthonykim1 marked this pull request as ready for review August 25, 2025 17:48
@anthonykim1 anthonykim1 requested a review from Tyriar August 25, 2025 17:48
@Tyriar Tyriar enabled auto-merge (squash) August 25, 2025 17:53
@Tyriar Tyriar merged commit 36559a0 into main Aug 25, 2025
18 checks passed
@Tyriar Tyriar deleted the anthonykim1/stickyScrollDefaultTrue branch August 25, 2025 18:00
@mhsmith
Copy link

mhsmith commented Aug 26, 2025

@anthonykim1: Sorry for posting on an unrelated page, but you sent me a message in #224750, which is a locked issue. Could you unlock it so I can reply?

@Tyriar
Copy link
Member

Tyriar commented Aug 26, 2025

@mhsmith unlocked, thanks for letting us know

osortega pushed a commit that referenced this pull request Aug 26, 2025
…ders (#263292)

* Enable terminal sticky scroll default true

* typo

* Remove stale import 'product' to fix compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling terminal sticky scroll by default in stable
3 participants